Michael Blow has submitted this change and it was merged. Change subject: [ASTERIXDB-2370][*DB] Modify the inconsistent method name "isFull" ......................................................................
[ASTERIXDB-2370][*DB] Modify the inconsistent method name "isFull" - taken from https://github.com/apache/asterixdb/pull/7 The method is named as "isFull". However, the method does set the boolean variable full. Thus, rename the method as "setFull" should be more intuitive than "isFull" since "isFull" is a query asking whether the object is full or not. Change-Id: I99bf451367171afb3fc0511a6170eb4c492fc69f Reviewed-on: https://asterix-gerrit.ics.uci.edu/2629 Contrib: Michael Blow <[email protected]> Integration-Tests: Michael Blow <[email protected]> Tested-by: Michael Blow <[email protected]> Sonar-Qube: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Michael Blow: Verified; ; Verified Murtadha Hubail: Looks good to me, approved diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java index a94f073..2ed2ac9 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java @@ -57,7 +57,7 @@ } } - public synchronized void isFull(boolean full) { + public synchronized void setFull(boolean full) { this.full.set(full); this.notify(); } diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java index 7a9d75f..6c8e372 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java @@ -167,7 +167,7 @@ private synchronized void appendToLogBuffer(ILogRecord logRecord) throws InterruptedException { if (!currentTxnLogBuffer.hasSpace(logRecord)) { - currentTxnLogBuffer.isFull(true); + currentTxnLogBuffer.setFull(true); if (logRecord.getLogSize() > logPageSize) { getAndInitNewLargePage(logRecord.getLogSize()); } else { -- To view, visit https://asterix-gerrit.ics.uci.edu/2629 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99bf451367171afb3fc0511a6170eb4c492fc69f Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
