Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2375][RT] Evaluate constant experession in SELECT only once ......................................................................
Patch Set 12: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2621/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java: PS12, Line 236: ADoubleSerializerDeserializer.getDouble why getOrDeserializeDouble() is not used here? Line 450: // if any exception happens, treat it as non-constant case. When can an exception happen here? SerializerDeserializer.get*() methods do not throw exceptions. Can we remove this try-catch block? -- To view, visit https://asterix-gerrit.ics.uci.edu/2621 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae4e78928da2bd63b2984b3624b88baed9b7cd73 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
