Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2383][FUN] Deployed Functions ......................................................................
Patch Set 2: (3 comments) Will address this comments in the next push. https://asterix-gerrit.ics.uci.edu/#/c/2611/2/asterixdb/asterix-app/src/test/resources/optimizerts/queries/deployed_function/deployed_function_non_key_lookup.sqlpp File asterixdb/asterix-app/src/test/resources/optimizerts/queries/deployed_function/deployed_function_non_key_lookup.sqlpp: PS2, Line 40: `get-job-param` > Could we add an alias that does not require backticks? yes. https://asterix-gerrit.ics.uci.edu/#/c/2611/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/deployed_function/deployed_function.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/deployed_function/deployed_function.1.ddl.sqlpp: PS2, Line 164: select element {'l_suppkey':l.l_suppkey,'l_extendedprice':l.l_extendedprice,'l_discount':l.l_discount,'l_quantity':l.l_quantity,'l_partkey':l.l_partkey,'l_orderkey':l.l_orderkey,'n_name':s1.n_name} : from ( : select element {'s_suppkey':s.s_suppkey,'n_name':n.n_name} : from Supplier as s, : Nation as n : where (n.n_nationkey = s.s_nationkey) : ) > Could we write this as this query was copied from one of the TPCH queries. We can sure change it to that to avoid constructors. https://asterix-gerrit.ics.uci.edu/#/c/2611/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/IFunctionManager.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/IFunctionManager.java: PS2, Line 36: FunctionSignature > Why do we need a FunctionSignature here when the other methods on the inter I used FunctionSignature just to avoid create a FunctionIdentifier at runtime. They serve the same purpose here. -- To view, visit https://asterix-gerrit.ics.uci.edu/2611 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c5a2f4c458ea7e19632d9fb9b5cd77b4e64a71f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
