Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2367][STO] Various Fixes for BufferCache ......................................................................
Patch Set 10: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2604/10/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: PS10, Line 849: fInfo = getOrCreateFileHandle(fileId); > so this is expected to be faster in situations with many merges/flushes bec Yes. And this method is very cheap (only involves a hash map lookup). However, in the previous case the synchronization block contains file creation/deletion on hard disk, which may take a long time if the disk is busy... -- To view, visit https://asterix-gerrit.ics.uci.edu/2604 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a199d3e83592425ab5055bd12bde519e80deb13 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
