Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code ......................................................................
Patch Set 15: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2320/15/asterixdb/asterix-dashboard/pom.xml File asterixdb/asterix-dashboard/pom.xml: PS15, Line 84: <exclude>src/main/resources/dashboard/static/*</exclude> : <exclude>src/main/resources/dashboard/node_modules/**</exclude> revert this, if you're using this to avoid RAT complaining during build just pass -Drat.skip instead https://asterix-gerrit.ics.uci.edu/#/c/2320/15/asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/datasets.component.scss File asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/datasets.component.scss: PS15, Line 64: padding: 0 14px 0 0; lets kill all the tabs, 4 spaces instead -- To view, visit https://asterix-gerrit.ics.uci.edu/2320 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Emilio Jose Coronado Lopez <emilio.mob...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Emilio Jose Coronado Lopez <emilio.mob...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
