Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery manager ......................................................................
Patch Set 2: Code-Review-1 (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2640/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java: PS2, Line 183: GlobalRecoveryManager IGlobalRecoveryManager? PS2, Line 183: ccExtensionManager Why not use the protected member ccExtensionManager? PS2, Line 185: GlobalRecoveryManager IGlobalRecoveryManager? PS2, Line 186: GlobalRecoveryManager not needed? https://asterix-gerrit.ics.uci.edu/#/c/2640/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java: PS2, Line 120: resetDeployedJobIdFactory This method seems problematic as it exposes internals. I think that the creation of DeployedJobSpecId should be owned by Hyracks and that the policy on how to do this is not exposed to/influenceable by the client. -- To view, visit https://asterix-gerrit.ics.uci.edu/2640 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
