Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2386][CLUS] Allow extension of the global recovery manager ......................................................................
Patch Set 3: (3 comments) Addressed Comments. Uploading a new patchset https://asterix-gerrit.ics.uci.edu/#/c/2640/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java: PS3, Line 184: getGlobalRecoveryManager > I think that we should keep this as a "create" methods (like the one above Done https://asterix-gerrit.ics.uci.edu/#/c/2640/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java: PS3, Line 132: getDataverse > Why do we call this here if we don't use the returned value? This one line is actually the whole fix for ASTERIXDB-2386. Basically the dataverses should be in the cache after recovery. https://asterix-gerrit.ics.uci.edu/#/c/2640/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IGlobalRecoveryManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IGlobalRecoveryManager.java: PS3, Line 32: create > I think that it'd be better to keep this interface clean and move these par Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2640 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1213e702a77ededde18ee0b50bc105212f43480d Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes