Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2318] Build dashboard in mvn ......................................................................
Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2648/6/asterixdb/pom.xml File asterixdb/pom.xml: PS6, Line 6: org.apache.asterix:asterix-dashboard:0.9.4-SNAPSHOT revert https://asterix-gerrit.ics.uci.edu/#/c/2648/6/asterixdb/src/main/licenses/templates/asterix-license.ftl File asterixdb/src/main/licenses/templates/asterix-license.ftl: PS6, Line 66: : === : ASTERIXDB Dashboard JS COMPONENTS: : : includes a number packed of subcomponents under : dashboard/static/ with separate copyright : notices and license terms. Your use of these subcomponents is subject : to the terms and condition of the following licenses. : === : <#include "3rdpartylicenses.txt"> I think we need to include the logic to optionally skip this, for packaging that may exclude dashboard. e.g. <#if !asterixDashboardSkip!false> https://asterix-gerrit.ics.uci.edu/#/c/2648/6/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/GenerateFileMojo.java File hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/GenerateFileMojo.java: PS6, Line 342: || shouldn't this be &&? -- To view, visit https://asterix-gerrit.ics.uci.edu/2648 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccea033d426f5d205658d1c11867f8aaab4d24ca Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
