Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2318] Build dashboard in mvn ......................................................................
Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2652/3/asterixdb/asterix-dashboard/.gitignore File asterixdb/asterix-dashboard/.gitignore: PS3, Line 1: src/main/resources/dashboard/static/* : src/main/resources/licenses/3rdpartylicenses.txt > why do we need to stage generated things in src? these should be in target we can either copy the node directory to target and exclude it in the build, or leave it in src. node is very inflexible about this. https://asterix-gerrit.ics.uci.edu/#/c/2652/3/asterixdb/asterix-server/pom.xml File asterixdb/asterix-server/pom.xml: PS3, Line 87: > why is this removed? ah actually this should be added in, last time i was trying to get the license added as if it was a thirdparty dependency -- To view, visit https://asterix-gerrit.ics.uci.edu/2652 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccea033d426f5d205658d1c11867f8aaab4d24ca Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
