Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Add variable resolution appendix ......................................................................
Patch Set 6: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2653/6/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md: PS6, Line 229: and the LET clause that follows it, if any > this is slightly confusing because if there's a LET after FROM then there a Better? PS6, Line 231: missing > minor. may be add backquotes around "missing" to indicate that this is a sp Done (also for the other 'missing's in the text). PS6, Line 237: Rule 2a > There's no Rule 2a. You meant 2.1, right? Yes, done. PS6, Line 247: foo > minor. may be replace 'foo' with something more meaningful, like 'salary', Done, 'salary' seems to match the context. -- To view, visit https://asterix-gerrit.ics.uci.edu/2653 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd4abd52f05d652d9436670b59beeb7cb6b846b5 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
