Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2318] Build dashboard in mvn ......................................................................
Patch Set 5: (3 comments) also a general comment- should we make sure this works on windows? https://asterix-gerrit.ics.uci.edu/#/c/2652/3/asterixdb/asterix-dashboard/.gitignore File asterixdb/asterix-dashboard/.gitignore: PS3, Line 1: src/main/resources/dashboard/static/* : src/main/resources/licenses/3rdpartylicenses.txt > we can either copy the node directory to target and exclude it in the build I would prefer that we stage sources into target as needed than generate files outside of target... https://asterix-gerrit.ics.uci.edu/#/c/2652/5/asterixdb/asterix-dashboard/pom.xml File asterixdb/asterix-dashboard/pom.xml: PS5, Line 32: <node.path>${user.home}/.node</node.path> what is this used for? PS5, Line 77: <exclude>src/main/resources/dashboard/static/* : </exclude> : <exclude>src/main/resources/licenses/* : </exclude> : <exclude>src/node/** : </exclude> this whitespace looks wierd -- To view, visit https://asterix-gerrit.ics.uci.edu/2652 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccea033d426f5d205658d1c11867f8aaab4d24ca Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
