Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2388] Add nodeIDs to cluster state query failure exception ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2654/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java: PS2, Line 84: Arrays.toString(inactiveNodes.toArray()) > Arrays.toString(x.toArray()) is redundant Done PS2, Line 85: " + "double check" + " > combine to a single string literal Done PS2, Line 75: if (!clusterStateManager.getState().equals(ClusterState.ACTIVE)) { : ClusterPartition[] configuredPartitions = clusterStateManager.getClusterPartitons(); : List<String> inactiveNodes = new ArrayList<>(); : for (ClusterPartition cp : configuredPartitions) { : if (!cp.isActive()) { : inactiveNodes.add(cp.getNodeId()); : } : } : throw new AsterixException("Not all node controllers required" + " for query execution" : + " have joined the cluster. Nodes " + Arrays.toString(inactiveNodes.toArray()) + " appear " : + "missing," + "double check" + " the logs on these machines and the cluster " : + "configuration"); : } else { : if (LOGGER.isInfoEnabled()) { : LOGGER.info("Cluster is now " + ClusterState.ACTIVE); : } : } > should synchronize on clusterStateManager Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2654 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8684f01c483595f1488537d82335d79f173f1517 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
