Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2391][SQL] Fix type casting to work with returning clause ......................................................................
Patch Set 7: (2 comments) Added two comments. Let me know if you want to talk about it. https://asterix-gerrit.ics.uci.edu/#/c/2675/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java: Line 82: private boolean planHasDistributeResult = false; I think all the rules ought to be stateless. Isn't it? Line 106: if (op1.getOperatorTag() == LogicalOperatorTag.DISTRIBUTE_RESULT) { I don't think I understand the rule logic here. To my understanding, if you just want to fix the casting in the returning case, would changing the distribute result part of the CASE statement be sufficient? I think it would be more efficient if we could talk about this and include Dimtry into the conversation as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/2675 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdd9f1c7afd3de1ca35934dc07386ea814521894 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
