Michael Blow has posted comments on this change. Change subject: [NO ISSUE][ING] Improvements to active retry policy ......................................................................
Patch Set 3: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2665/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java: PS3, Line 213: listeners inline https://asterix-gerrit.ics.uci.edu/#/c/2665/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java: PS3, Line 88: why removed? PS3, Line 448: Thread.currentThread().setName(Thread.currentThread().getName() + getClass().getSimpleName()); if we alter the thread, we should restore it in a finally PS3, Line 461: LOGGER.log(Level.ERROR, () -> "Thread dump at halt: " + ThreadDumpUtil.takeDumpString()); i think we should do this on all halts- move to ExitUtil.halt()? -- To view, visit https://asterix-gerrit.ics.uci.edu/2665 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4246e2a276e1f80569a07630e182aab8f49dd115 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
