abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-remove() ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2693/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java: PS2, Line 1467: addFunction(RECORD_REMOVE, OpenARecordTypeComputer.INSTANCE, true); : addFunction(RECORD_REMOVE_STRICT, OpenARecordTypeComputer.INSTANCE, true); shouldn't the output type be based on the input type? -- To view, visit https://asterix-gerrit.ics.uci.edu/2693 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d4acfa0ef00ccdcb95e189b989a16f06acf0119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
