Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2708/1/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.3.query.sqlpp: Line 34: object_replace("non-object", "a", "z") is null > in n1ql object_replace({"a":1}, {"b":2}, "z") returns { "a": 1 } Done. I added an ugly primitive type to use it in the type mismatch exception to avoid listing all primitive types. If you don't like it, let's find an alternative. PS1, Line 35: > object_replace({"a":1}, "b", ["z"]) is not a deep equality case and it is s We now return {"a":1} Line 37: "t3": object_replace({"a":"1", "b":2}, 2, "3"), > let's to add testcases: Done https://asterix-gerrit.ics.uci.edu/#/c/2708/1/asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md File asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md: Line 368: * The value of the single name-value pair that appears in `input_object`, > we call these types primitive in the documentation, not atomic. (applies to Done Line 374: > 1) (see my other comment on the testcase) if the old_value is not a primiti Done. We don't return null anymore. https://asterix-gerrit.ics.uci.edu/#/c/2708/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java: Line 652: fc.addGenerated(RecordRenameDescriptor.FACTORY); > it looks like this function cannot use byte-code generated runtime because a blessing in disguise :) -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
