Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-replace() ......................................................................
Patch Set 5: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.4.query.sqlpp: Line 22: * Expected Res : Failure > Expected Res should be "Failure". Done https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_replace/object_replace.5.query.sqlpp: Line 22: * Expected Res : Failure > Expected Res should be "Failure" Done https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java: Line 71: > let's not introduce a new type tag just for error reporting purposes. Done https://asterix-gerrit.ics.uci.edu/#/c/2708/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordReplaceEvaluator.java: Line 94: } > you could use oldValueType.isDerived() here Done Line 100: final ATypeTag newValueType = PointableHelper.getTypeTag(newValuePointable); > or an array/multiset because an array/multiset can contain objects too. use Done Line 117: final IVisitablePointable fieldValue = fieldValues.get(i); > using RawBinaryComparatorFactory might be a problem here for comparing diff Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2708 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2907f827a1dc5bb35f340bfd25d51e1fdd6fde20 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
