Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][ING] Cleanup active listener
......................................................................


Patch Set 6:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2618/6/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java
File 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java:

PS6, Line 39: The activity has been started successfully and is running
fix comment


https://asterix-gerrit.ics.uci.edu/#/c/2618/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java:

PS6, Line 462: appCtx
+1


PS6, Line 464: locations
+1


https://asterix-gerrit.ics.uci.edu/#/c/2618/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/FeedEventsListener.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/FeedEventsListener.java:

PS6, Line 82: The current implementation of the wait for completion flag is 
problematic
Do we have an issue for this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2618
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3b14aec46728fbe8b256b915d0e30992b2fe47
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to