Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-add(), object-put() ......................................................................
Patch Set 7: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2713/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddEvaluator.java: PS7, Line 71: evaluate > Could we/should we share this code between both functions? I wonder about that too. As we create more functions we should explore opportunities for code sharing. Function evaluators for functions that are not code-generated can extend the same base class or even have deeper class hierarchy. Evaluators for code-generated functions can extend the same base class only if they have the same number of arguments. If they have different numbers of arguments then code-sharing is possible through helper classes (look at StringTrimmer and how it's used by string trim functions) -- To view, visit https://asterix-gerrit.ics.uci.edu/2713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0b33f4ea82752ced0b5fc8f54d4474711192fc Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
