Xikui Wang has posted comments on this change. Change subject: Improve performance of NotifyBrokerRuntime code ......................................................................
Patch Set 1: (6 comments) Added several comments. https://asterix-gerrit.ics.uci.edu/#/c/2717/1/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java File asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java: Line 99: listPrinterFactory = -> subscriptionIdPrinter ? Line 114: String JSON = "{ \"dataverseName\":\"" + entityId.getDataverse() + "\", \"channelName\":\"" let's take this chance to rename this variable to jsonStr. JSON is an actual library name. PS1, Line 177: + 1 What's this +1 for? Line 178: endpoint = stringSerDes.deserialize(di).getStringValue(); It seems the endpoint comes from one of the record field value? Do we have the record schema somewhere? If not, could you add some comments before this method? Line 181: sendStreams.putIfAbsent(endpoint, new PrintStream(sendbaos.get(endpoint), true, "UTF-8")); use standard charset as well Line 193: sendStreams.get(endpoint)); uncheck firstResult? -- To view, visit https://asterix-gerrit.ics.uci.edu/2717 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ecd381d102c67f7c66cfa965312bfb885aa281 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
