Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE][COMP] Prevent broadcast hint changes left-outer-join semantic ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2721/1/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java: Line 71: } else if ((side == BroadcastSide.LEFT && !(op instanceof LeftOuterJoinOperator))) { > MAJOR SonarQube violation: let's not use instanceof as we already have AbstractBinaryJoinOperator.JoinKind for this purpose. Can you modify it as follows: 1) keep the swtich statement. 2) in "case LEFT" do: if (op.getJoinKind() == INNER) then { assign BROADCAST } else { assign PAIRWISE } 3) in "case default" throw IllegalStateException(side.toString()); the code should not reach it because we only have two sides. -- To view, visit https://asterix-gerrit.ics.uci.edu/2721 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522b5f1edf35a1c46f2e2ef1b265049d3c18a575 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
