Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_position function ......................................................................
Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2714/2/asterixdb/asterix-app/src/test/resources/runtimets/only_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/only_sqlpp.xml: Line 21: <test-group name="array_fun"> why add this testcase here in addition to testsuite_sqlpp.xml? https://asterix-gerrit.ics.uci.edu/#/c/2714/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java: Line 142: public final boolean isComplexType() { you won't see UNION types at runtime, so you could use isDerivedType() in your evaluator code. can we remove this method? Line 146: // TODO(ali): clean up all references and replace with this method call can we remove this TODO item? file an issue if you want to track this work instead. https://asterix-gerrit.ics.uci.edu/#/c/2714/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPositionDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPositionDescriptor.java: Line 115: IBinaryComparator comp = AObjectAscBinaryComparatorFactory.INSTANCE.createBinaryComparator(); create all instances in the constructor and reuse here: comp, listAccessor, intValue Line 135: ISerializerDeserializer intSerde = create intSerde in the constructor. -- To view, visit https://asterix-gerrit.ics.uci.edu/2714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4604d347a22f98071a68abee43693fca9096b361 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
