Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement object-values() ......................................................................
Patch Set 4: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2718/3/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/object_values/object_values.3.query.sqlpp: Line 45: select value object_values(m) > ojbect_values() is supposed to have only one argument. how come this query Done https://asterix-gerrit.ics.uci.edu/#/c/2718/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java: Line 231: public static final FunctionIdentifier RECORD_ADD = > object_values() takes only one argument, not varargs. I discussed this with Till. I made it varargs similar to object-pairs, but I agree that it should be one. I changed it to 1. -- To view, visit https://asterix-gerrit.ics.uci.edu/2718 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I804fb75d20837ae01b8f34f6389dcb3480ce5548 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
