Xikui Wang has posted comments on this change. Change subject: [COMP] Maintain schemas for delegate operators ......................................................................
Patch Set 1: (1 comment) One minor comment. I think CB guys need to look at it. https://asterix-gerrit.ics.uci.edu/#/c/2726/1/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DelegateOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DelegateOperator.java: Line 54: this.setSchema(schema); Instead of set this schema, should we change line 93 to return the delegate schema? -- To view, visit https://asterix-gerrit.ics.uci.edu/2726 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8723e686d741bf3098ff44d046cde5239e204b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
