Dmitry Lychagin has posted comments on this change. Change subject: [COMP] Maintain schemas for delegate operators ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2726/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java: Line 109: extensionOperator.setSchema(op.getSchema()); can you describe the problem? why was DelegateOperator.recomputeSchema() not sufficient? (i.e. why do you need to set the schema there instead of setting the input below and letting recomputeSchema() do its job?) -- To view, visit https://asterix-gerrit.ics.uci.edu/2726 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8723e686d741bf3098ff44d046cde5239e204b Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
