Dmitry Lychagin has posted comments on this change. Change subject: [COMP] Maintain schemas for delegate operators ......................................................................
Patch Set 7: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2726/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DelegateOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DelegateOperator.java: Line 93: return delegate.getSchema(); I still don't see why this is needed. DelegateOperator is the owner of the schema because it can recompute it from its inputs (recomputeSchema()). Every time it does that it makes the schema available to IOperatorDelegate (delegate.setSchema()). The delegate cannot compute the schema by itself, so cannot be its owner. It looks like DelegateOperator.schema and AbstractDelegatedLogicalOperator.schema should always point to the same list of variables. Is it not the case? When can they diverge? Do you have an example describing the problem or an existing issue that was filed? -- To view, visit https://asterix-gerrit.ics.uci.edu/2726 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8723e686d741bf3098ff44d046cde5239e204b Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
