Till Westmann has posted comments on this change. Change subject: Miscellaneous Improvements ......................................................................
Patch Set 3: (3 comments) Only philosophical comments. https://asterix-gerrit.ics.uci.edu/#/c/2733/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java: PS3, Line 25: AdmArrayNode I'd expect AdmNodes to build upon the primitives of the pointables and the builders, but not the other way around. Or maybe there's a translator that takes a Pointable and constructs an AdmNode and thus builds on both. https://asterix-gerrit.ics.uci.edu/#/c/2733/3/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/AbstractPointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/AbstractPointable.java: PS3, Line 23: Serializable That doesn't seem right. A Pointable is essentially a pointer with attached methods that work on the serialized representation. Why should that be serializable? https://asterix-gerrit.ics.uci.edu/#/c/2733/3/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringWriter.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringWriter.java: PS3, Line 25: Serializable Why does this writer need to be serializable? -- To view, visit https://asterix-gerrit.ics.uci.edu/2733 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705e75d573a7f2c888dd7d83b4c24a2c7050eb88 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
