Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2402][COMP] Allow AND for IsMissing in Groupby ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2735/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 1505: //find IS_MISSING function of which argument has the nullPlaceholder variable in the nested plan of groupby. Do we check that the variable inside is_missing() is the one we need? I could not find it in the previous code and the current code does not seem to do it either. In your comment you say "and(not(is-missing($VAR1)),not(is-missing($VAR2)))". What if we're looking for $VAR2 instead of $VAR1? Can you double check what happens this case while looking into this issue. https://asterix-gerrit.ics.uci.edu/#/c/2735/2/asterixdb/asterix-app/src/test/resources/optimizerts/queries/ASTERIXDB-2402.sqlpp File asterixdb/asterix-app/src/test/resources/optimizerts/queries/ASTERIXDB-2402.sqlpp: Line 102: insert into channels.EmergenciesNearMeChannelResults as a ( can we simplify the statement here? Is the insert necessary or a simpler query could reproduce this issue? -- To view, visit https://asterix-gerrit.ics.uci.edu/2735 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9547fba5e4ba02226b5b2c2504080b091d3b8d5e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
