Till Westmann has posted comments on this change. Change subject: Miscellaneous Improvements ......................................................................
Patch Set 4: (1 comment) Looks ok - just a bit confused about the package of AdmNodeUtils.java (but that's not critical). However, we should have a better commit message. https://asterix-gerrit.ics.uci.edu/#/c/2733/4/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/AdmNodeUtils.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/AdmNodeUtils.java: PS4, Line 19: om.utils Shouldn't this be closer to object.base - where the AdmNodes are? -- To view, visit https://asterix-gerrit.ics.uci.edu/2733 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705e75d573a7f2c888dd7d83b4c24a2c7050eb88 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
