Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][FUN] Implement array_prepend() function ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2739/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArrayAppendPrependEval.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArrayAppendPrependEval.java: Line 42: public abstract class AbstractArrayAppendPrependEval implements IScalarEvaluator { > array_prepend() = array_insert() at position = 0, array_append() = array_in Done. I added array_remove() and array_put() also because they share quite a lot of code and only differ in the way they add/remove values to the input list. https://asterix-gerrit.ics.uci.edu/#/c/2739/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java: Line 381: fc.addGenerated(ArrayPrependDescriptor.FACTORY); > As I mentioned in the array_insert() review it looks like you cannot use co Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2739 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccfe54e126700724fd393b5c6a6de6f3aa6db9ce Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
