Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2402][COMP] Allow AND for IsMissing in Groupby ......................................................................
Patch Set 12: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2735/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 1539: } else if (currentOp.hasNestedPlans()) { > This is new, right? Does your testcase require this or not? If not then let The test case does actually use this. When I was looking again to address your last comment I realized that there was another missed opportunity for detecting the missing check, so I went ahead and fixed that as well. In the end, the final plan for my test comes out with a only a few small differences, but it definitely exercises this new code. -- To view, visit https://asterix-gerrit.ics.uci.edu/2735 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9547fba5e4ba02226b5b2c2504080b091d3b8d5e Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
