Ian Maxon has posted comments on this change. Change subject: [NO ISSUE] Asterixdb-dashboard baseline: ......................................................................
Patch Set 3: (11 comments) https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/package.json File asterixdb/asterix-dashboard/src/node/package.json: PS3, Line 15: { if we can remove all of the wildcard dependencies it would be nice, i tried removing them earlier and it broke things so i am not sure how simple it will be https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/dashboard/apptab.component.html File asterixdb/asterix-dashboard/src/node/src/app/dashboard/apptab.component.html: PS3, Line 14: <mat-tab-group class="menu"> : <mat-tab label=">_ QUERY"> : <div class="query-tab"> : <awc-query-container></awc-query-container> : <div class='flex-spacer'></div> : <div class="apache"> : <img src="./assets/feather.png" style="height:20px"> : <span class="caret">Apache Software Foundation - Asterixdb Dashboard</span> : </div> : </div> : </mat-tab> : </mat-tab-group> if there's only one tab now maybe we can just dispense with this ? https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/input.component.ts File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/input.component.ts: PS3, Line 34: "Use Metadata; select * from CompactionPolicy"; should be empty PS3, Line 163: //this.sideMenuVisible$ = this.store.select(s => s.app.sideMenuVisible); : //this.sideMenuVisible$.subscribe((data: any) => { : // if (data) { : // this.sideMenuVisible = data; : // } : //}) : //this.store.dispatch(new dataverseActions.SelectDataverses('-')); let's remove the commented out code https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-node-svg.component.scss File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-node-svg.component.scss: PS3, Line 100: // display: flex; : // .title { : // font-size: 10px; : // font-weight: 500; : // color: blue; : // //padding-top: 12px; : // } : // } : // .details { : // padding-top: 10px !important; : // padding-bottom: 20px !important; : // margin: 0px !important; : // overflow: auto; : // font-size: 10px; : // text-align: left; : // visibility: hidden; : // transition: opacity 1s ease-in-out; : // opacity: 0; : // } : &:hover { if this part of the style isn't used let's remove it PS3, Line 184: /* .merge { : display: flex; : flex-flow: row; : margin-top: 0 !important; : list-style: none; : padding-left: 0; : color: #00B5E2 !important; : border: 1px dashed #00B5E2; : justify-content: center; : }*/ " https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-node-svg.component.ts File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-node-svg.component.ts: PS3, Line 87: : // var mycircle = document.getElementById('node'+ this.level + this.item + this.subplan + this.planName); : : // mycircle.addEventListener('click', function(e) { : // console.log('clicked - enlarging: ' + 'node'+ this.level + this.item + this.subplan + this.planName); : // }, false); : : // let global = this.renderer.listen(mycircle, 'click', (evt) => { : // console.log('Clicking the document', evt); : // console.log('clicked - enlarging: ' + 'node'+ this.level + this.item + this.subplan + this.planName); : // }) : : // var svg = document.getElementById('mysvg'+ this.level + this.item + this.subplan + this.planName), : // NS = svg.getAttribute('xmlns'); : : // add random circles : /*var c, i; : for (i = 0; i < 1000; i++) { : c = document.createElementNS(NS, 'circle'); : c.setAttributeNS(null, 'cx', Math.round(Math.random() * 100)); : c.setAttributeNS(null, 'cy', Math.round(Math.random() * 100)); : c.setAttributeNS(null, 'r', 1 ); // 20 + Math.round(Math.random() * 30)); : svg.appendChild(c); : }*/ : : /* click a circle : svg.addEventListener('click', function(e) { : var t = e.target; : if (t.nodeName != 'circle') return; : t.setAttributeNS(null, 'r', : parseFloat(t.getAttributeNS(null, 'r')) + 10 : ); : console.log(t.getBoundingClientRect()); : }, false); */ : //global(); : // let simple = this.renderer.listen(this.myButton.nativeElement, 'click', (evt) => { : // console.log('Clicking the button', evt); : // }); : //simple(); : //Adding classes for further granularity/level styling : //console.log('node'+ this.level + this.item + this.subplan + this.planName); : //var svg = document.getElementById('node'+ this.level + this.item + this.subplan + this.planName); : //svg.className.baseVal = ... or svg.setAttribute("class", ...) or svg.classList.add(...) or. : //svg.classList.add("level" + this.level + "item" + this.item);svg.classList.add("subplan" + this.subplan); : //svg.classList.add("planName" + this.planName); " PS3, Line 224: console.log(me); : console.log(this.viewParams_) : : if (this.viewParams_.viewMode === 'NORMAL') { : this.viewParams_ = FULL; : console.log('FULL') : } else { : this.viewParams_ = NORMAL; : console.log('NORMAL') : } : : var ele = document.getElementById('node'+ this.level + this.item + this.subplan + this.planName); : (<any>ele).style.width = this.viewParams_.width; : (<any>ele).style.height = this.viewParams_.height; : console.log(ele); : if (this.viewParams_.viewMode === "FULL") { : (<any>ele).style.height = "unset"; : (<any>ele).style.maxHeight = this.viewParams_.height; : } : var ele2 = document.getElementById('node'+ this.level + this.item + this.subplan + this.planName).getElementsByClassName('operation-details'); : console.log(ele2); : : (<any>ele2[0]).style.visibility = this.viewParams_.visible; : (<any>ele2[0]).style.opacity = this.viewParams_.opacity; : : var ele3 = document.getElementById('node'+ this.level + this.item + this.subplan + this.planName).getElementsByClassName('operation-details'); : (<any>ele3[0]).style.borderTop = this.viewParams_.border; : console.log(ele3); */ : } could hide this behind some sort of debug flag https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-view.component.ts File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-view.component.ts: PS3, Line 89: /*if (this.checkOperationId(nodes['inputs'][i].operatorId, planCounter.levelsCnt)) { : nodes['mergeWith'] = nodes['inputs'][i].operatorId; : nodes['mergeOpName'] = nodes['inputs'][i].operator; : nodes['inputs'] = []; : break; : } : else { : planCounter = this.analyzePlan(nodes['inputs'][i], planCounter); : }*/ " https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/tree-view.component.ts File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/tree-view.component.ts: PS3, Line 314: //var nestedObjectStr = JSON.stringify(data[i][resultKey][nestedKeyList[k]], null, '\n'); : //this.flattenData[i] = nestedObjectStr " https://asterix-gerrit.ics.uci.edu/#/c/2755/3/asterixdb/asterix-dashboard/src/node/src/app/db.ts File asterixdb/asterix-dashboard/src/node/src/app/db.ts: PS3, Line 29: // import { DBSchema } from '@ngrx/db'; : : : /** : * ngrx/db uses a simple schema config object to initialize stores in IndexedDB. : */ : //export const schema: DBSchema = { : // version: 1, : // name: 'books_app', : // stores: { : // books: { : // autoIncrement: true, : // primaryKey: 'id' : // } : // } : //}; lets get rid of this? -- To view, visit https://asterix-gerrit.ics.uci.edu/2755 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I560911173486b0063fb4ffe9612a2ae2f1307c81 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Emilio Jose Coronado Lopez <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
