Ian Maxon has posted comments on this change. Change subject: [NO ISSUE] Asterixdb-dashboard baseline: ......................................................................
Patch Set 7: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/2755/7/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/metadata-inspector.component.scss File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/metadata-inspector.component.scss: PS7, Line 23: //color: rgb(145, 152, 158); Remove comment https://asterix-gerrit.ics.uci.edu/#/c/2755/7/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/metadata.component.scss File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/metadata.component.scss: PS7, Line 45: //background-color: gainsboro; " PS7, Line 54: font-size: 0.80rem; : font-weight: 500; // color:rgb(145, 1 " https://asterix-gerrit.ics.uci.edu/#/c/2755/7/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-node-svg.component.html File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-node-svg.component.html: PS7, Line 14: <!--<svg id='mysvg{{level}}{{item}}{{subplan}}{{planName}}' xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" : width="50px" height="50px" viewBox="0 0 50 50" preserveAspectRatio="xMidYMid meet"></svg> --> " PS7, Line 74: <!--<line x1="0" y1="30" x2="200" y2="30" stroke="blue" /> --> : <!--<text class="operation-details" x="50%" y="50" text-anchor="middle">{{details}}</text> --> " PS7, Line 78: !--<svg id='node{{level}}{{item}}{{subplan}}{{planName}}' xmlns="http://www.w3.org/2000/svg" xml:lang="en" class="dot" : xmlns:xlink="http://www.w3.org/1999/xlink" : width="10px" height="50px"> : <title>Connection</title> : <circle cx="5" cy="5" r="5"/> : <line x1="5" y1="10" x2="5" y2="50" stroke="blue" /> : <circle cx="5" cy="45" r="5"/> : </svg> -- " PS7, Line 96: <div class="merge" *ngIf="checkMerge()"> : <P>MERGE WITH</P> : <P>{{node['mergeWith']}} : {{node['mergeOpName'].toUpperCase()}}</P> : </div>--> " https://asterix-gerrit.ics.uci.edu/#/c/2755/7/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-view.component.scss File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/plan-view.component.scss: PS7, Line 70: padding: 20px; : //padding-right: 50px; " PS7, Line 72: //margin-right: 25px; " PS7, Line 78: //border-left: 1px solid gray; : padding-left: 25px; //display: inline-block; : //margin: auto; : } " https://asterix-gerrit.ics.uci.edu/#/c/2755/7/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/tree-node.component.ts File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/tree-node.component.ts: PS7, Line 40: // this.nodeChildren = this.node.children; " https://asterix-gerrit.ics.uci.edu/#/c/2755/7/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/tree-view.component.scss File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/tree-view.component.scss: PS7, Line 101: border-radius: 4px; : // padding: 10px; : height: 40px; : // background-color: #8CCDD1; " PS7, Line 112: //padding: .5em; : font-size: 14px; " -- To view, visit https://asterix-gerrit.ics.uci.edu/2755 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I560911173486b0063fb4ffe9612a2ae2f1307c81 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Emilio Jose Coronado Lopez <emilio.mob...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-HasComments: Yes