Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][ING] Add timeout to stop active message
......................................................................


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2762/2/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/StopRuntimeContent.java
File 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/StopRuntimeContent.java:

PS2, Line 26: StopRuntimeContent
s/StopRuntimeContent/StopRuntimeParameters/ ?


https://asterix-gerrit.ics.uci.edu/#/c/2762/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java:

PS2, Line 77: STOP_MESSAGE_TIMEOUT
Restore the comment?

// TODO: Make configurable https://issues.apache.org/jira/browse/ASTERIXDB-2065


https://asterix-gerrit.ics.uci.edu/#/c/2762/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java:

PS2, Line 69: getName
Use simple name instead?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2762
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0416d76670e945cb958f5a1c235201a3e016009
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to