abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][MISC] Add ping function
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2764/1//COMMIT_MSG
Commit Message:

PS1, Line 14: parameter
> s/parameter/parameters/
Done


PS1, Line 15: return
> s/return/returns/
Done


https://asterix-gerrit.ics.uci.edu/#/c/2764/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/PingReader.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/PingReader.java:

PS1, Line 43: CharArrayRecord record = new CharArrayRecord();
            :         record.reset();
            :         record.append(("{\"node\":\"" + nodeId + 
"\"}").toCharArray());
            :         record.endRecord();
            :         return record;
> I'd like to write this as
+1


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2764
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic077a11b61dec782756e2dede33ca8220893a2de
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to