Xikui Wang has uploaded a new patch set (#2). Change subject: [ASTERIXDB-2412][COMP] ExtractCommonExpressionsRule fix ......................................................................
[ASTERIXDB-2412][COMP] ExtractCommonExpressionsRule fix - user model changes: no - storage format changes: no - interface changes: no Details: ExtractCommonExpressionsRule should not be applied to JOIN by using Cartesian Product + SELECT since it will add extract overhead. Also, blindly adding SELECT without checking GROUP-BY and other possible OPs in between could cause type inference error. Change-Id: I20e1fa161c42e0494c7ca587b8bffdc80d656058 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/comp-ASTERIXDB-2412/comp-ASTERIXDB-2412.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/comp-ASTERIXDB-2412/comp-ASTERIXDB-2412.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/comp-ASTERIXDB-2412/comp-ASTERIXDB-2412.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/extract_common_expr-ASTERIXDB-2412/extract_common_expr-ASTERIXDB-2412.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java 6 files changed, 144 insertions(+), 31 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/2770/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2770 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20e1fa161c42e0494c7ca587b8bffdc80d656058 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]>
