Till Westmann has posted comments on this change. Change subject: [NO ISSUE][MISC] Introduce IClientRequest ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2774/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/ExtensionStatement.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/ExtensionStatement.java: PS3, Line 56: clientContextId The clientContextId is part of the requestParameters already. https://asterix-gerrit.ics.uci.edu/#/c/2774/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java: PS3, Line 27: IStatementExecutorContext Is this being used in this file? https://asterix-gerrit.ics.uci.edu/#/c/2774/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS3, Line 42: IStatementExecutorContext Why is the IStatementExecutorContext in a different package than the IStatementExecutor? -- To view, visit https://asterix-gerrit.ics.uci.edu/2774 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f65da1744ea7ecf26ea3f8a576ebaf4472ccd62 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
