Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][FUN] Implement array functions p3
......................................................................


Patch Set 4: Contrib+1

(3 comments)

Overriding contrib vote

https://asterix-gerrit.ics.uci.edu/#/c/2790/2/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml:

PS2, Line 1092: ASX1087
Remove the error code as for the other tests?


https://asterix-gerrit.ics.uci.edu/#/c/2790/2/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS2, Line 75: 38
> 37 is above, in line 41: (37,1091)
Thanks!


https://asterix-gerrit.ics.uci.edu/#/c/2790/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayIntersectDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayIntersectDescriptor.java:

PS2, Line 148: 
> Done. You were referring to the listsArgs, right?
Yes, sorry.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2790
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida0d12d48f8c676d5a93b024c301dd13ef400247
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to