abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2802

Change subject: Stop archiving jobs
......................................................................

Stop archiving jobs

Change-Id: I7bc435e63e2c661b349b3323c0abe049cf225c1e
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/2802/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
index 3ba25f5..40963c7 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
@@ -140,7 +140,7 @@
                     
Collections.singletonList(HyracksException.create(ErrorCode.JOB_CANCELED, 
jobId));
             // Since the job has not been executed, we only need to update its 
status and lifecyle here.
             jobRun.setStatus(JobStatus.FAILURE_BEFORE_EXECUTION, exceptions);
-            runMapArchive.put(jobId, jobRun);
+            archive(jobId, jobRun);
             runMapHistory.put(jobId, exceptions);
             CCServiceContext serviceCtx = ccs.getContext();
             if (serviceCtx != null) {
@@ -232,9 +232,8 @@
         run.setStatus(run.getPendingStatus(), run.getPendingExceptions());
         run.setEndTime(System.currentTimeMillis());
         activeRunMap.remove(jobId);
-        runMapArchive.put(jobId, run);
+        archive(jobId, run);
         runMapHistory.put(jobId, run.getExceptions());
-
         if (run.getActivityClusterGraph().isReportTaskDetails()) {
             /*
              * log job details when profiling is enabled
@@ -287,6 +286,13 @@
         return jobRun;
     }
 
+    private void archive(JobId jobId, JobRun jobRun) {
+        // Note: If job lifecycle was designed correctly,
+        // then having an archive of size 0 shouldn't matter
+        // Uncomment the following line to enable archiving
+        // runMapArchive.put(jobId, jobRun);
+    }
+
     @Override
     public List<Exception> getExceptionHistory(JobId jobId) {
         List<Exception> exceptions = runMapHistory.get(jobId);

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2802
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc435e63e2c661b349b3323c0abe049cf225c1e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>

Reply via email to