Till Westmann has posted comments on this change. Change subject: Change License Headers ......................................................................
Patch Set 4: -Code-Review (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/388/4/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/GregorianCalendarSystem.java File asterix-om/src/main/java/org/apache/asterix/om/base/temporal/GregorianCalendarSystem.java: Line 46 > Ohh, Hmm, I was thinking since it was apache licensed it wasn't an issue. B Actually, you are right. There's nothing that requires a notice, so we shouldn't put one into the NOTICE file. But I think that this might fall under http://www.apache.org/legal/src-headers.html#3party unless there have been significant changes to the file. Also, I've just filed https://issues.apache.org/jira/browse/ASTERIXDB-1097 -- To view, visit https://asterix-gerrit.ics.uci.edu/388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09bc388089e515d7f51fd39c31bfbbc9f00cf84f Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
