Till Westmann has posted comments on this change. Change subject: Set the priority of the following threads to be Thread.MAX_PRIORITY: 1. heartbeat thread at NC 2. IPC network thread 3. work queue thread in CC ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/389/4/hyracks/hyracks-client/src/test/java/org/apache/hyracks/client/heartbeat/HeartBeatTest.java File hyracks/hyracks-client/src/test/java/org/apache/hyracks/client/heartbeat/HeartBeatTest.java: Line 59: cpuConsumers[i].setPriority(Thread.MIN_PRIORITY); Should this be NORM_PRIORITY as the other worker threads? Also, did you see an improvement in this test with the changes to the priorities (without changing the timeouts)? https://asterix-gerrit.ics.uci.edu/#/c/389/4/hyracks/hyracks-client/src/test/java/org/apache/hyracks/client/stats/HyracksUtils.java File hyracks/hyracks-client/src/test/java/org/apache/hyracks/client/stats/HyracksUtils.java: Line 61: ccConfig.maxHeartbeatLapsePeriods = 5; What was the default before? https://asterix-gerrit.ics.uci.edu/#/c/389/4/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java File hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java: Line 300: timerThread.setPriority(Thread.MAX_PRIORITY); This looks slightly hackish :) -- To view, visit https://asterix-gerrit.ics.uci.edu/389 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e53a85e21a6bdee48a3ca8d004569700f911fbd Gerrit-PatchSet: 4 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
