Heri Ramampiaro has posted comments on this change. Change subject: Merging with the current master (+ Correcting RecordBuilder instatiation in RecordAddFieldsDescriptor) ......................................................................
Patch Set 10: (3 comments) I will have the suggested corrections completed right a way. I will also make the patch compatible with the current master. Thanks, -heri https://asterix-gerrit.ics.uci.edu/#/c/298/10/asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml File asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml: Line 15: <test-case FilePath="records"> > Why change the indentation? Ah. The indention was by Intellij. I have already corrected it. Thanks. https://asterix-gerrit.ics.uci.edu/#/c/298/10/asterix-app/src/test/resources/runtimets/testsuite.xml File asterix-app/src/test/resources/runtimets/testsuite.xml: Line 6789: <test-group name="deep-equal"> > Can you add these tests similar to the Records tests? Separate file that is Done https://asterix-gerrit.ics.uci.edu/#/c/298/10/asterix-doc/src/site/markdown/aql/functions.md File asterix-doc/src/site/markdown/aql/functions.md: Line 2545: > I see these red highlights. Do you know what these are? Are these unexpecte Yes, It seems so. Thank you for pointing this out. I will remove them (they were added by Intellij it seems:-() -- To view, visit https://asterix-gerrit.ics.uci.edu/298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
