Till Westmann has posted comments on this change.

Change subject: Add Docker demo image to build
......................................................................


Patch Set 5:

(3 comments)

Could we add a license to the Dockerfile and supervisord.conf?

https://asterix-gerrit.ics.uci.edu/#/c/294/5/asterix-docker/docker/.gitattributes
File asterix-docker/docker/.gitattributes:

Line 1: *.adm binary
Is this specific to this change?


https://asterix-gerrit.ics.uci.edu/#/c/294/5/asterix-docker/docker/Dockerfile
File asterix-docker/docker/Dockerfile:

Line 1: FROM centos
Can we have comments/a license in here?


https://asterix-gerrit.ics.uci.edu/#/c/294/5/asterix-docker/docker/supervisord.conf
File asterix-docker/docker/supervisord.conf:

Line 1: [supervisord]
Can we add comments/a license here?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/294
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ca6667fecb8d0b6f758b97ccc0b12110c833ea
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Chris Hillery <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to