Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1136: Make Java compiler target configurable via profile ......................................................................
Patch Set 6: Code-Review+2 (3 comments) Looks good. There are a few whitespace improvements that could be made (but we can also do that in one bigger step). https://asterix-gerrit.ics.uci.edu/#/c/273/6/hyracks/hyracks-net/pom.xml File hyracks/hyracks-net/pom.xml: Line 43: WS? https://asterix-gerrit.ics.uci.edu/#/c/273/6/hyracks/pom.xml File hyracks/pom.xml: Line 98: WS? https://asterix-gerrit.ics.uci.edu/#/c/273/6/pom.xml File pom.xml: Line 201: For example, we exclude the KEYS file from the zip --> Would be nice to align a) the indentation of the comments with the indentation of the elements and b) the indentation here with the other indentation in the file (I think it's 2 spaces further below ... but it's clearly not consistent in the file ..) -- To view, visit https://asterix-gerrit.ics.uci.edu/273 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10378f9d3fdec9b4951f53c9b370b7741668e537 Gerrit-PatchSet: 6 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
