Till Westmann has posted comments on this change. Change subject: Fixed bug ASTERIXDB-1126 Turned out, the fix for ASTERIXDB-1115 introduced this bug. the reason is that it tries to get the data type for the primary key from the record type definition. In case of external data, the type definition doesn't contain inform ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/455/2/asterix-app/pom.xml File asterix-app/pom.xml: Line 116: </plugin> Please use spaces instead of tabs. https://asterix-gerrit.ics.uci.edu/#/c/455/2/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java File asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java: Line 80: WS Line 87: //dfsCluster = new MiniDFSCluster(nameNodePort, conf, numDataNodes, true, true, StartupOption.REGULAR, null); Can we remove this commented code? https://asterix-gerrit.ics.uci.edu/#/c/455/2/asterix-installer/src/test/java/org/apache/asterix/installer/transaction/RecoveryIT.java File asterix-installer/src/test/java/org/apache/asterix/installer/transaction/RecoveryIT.java: Line 83: WS https://asterix-gerrit.ics.uci.edu/#/c/455/2/asterix-installer/src/test/resources/transactionts/testsuite.xml File asterix-installer/src/test/resources/transactionts/testsuite.xml: Line 27: </test-group> The indentation seems wrong. https://asterix-gerrit.ics.uci.edu/#/c/455/2/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java: Line 842: } catch (IOException | AsterixException e) { Even though we only have 2 DatasetTypes right now, I think that it would be wise to put a switch in here and to throw if an unknown dataset type passes by. -- To view, visit https://asterix-gerrit.ics.uci.edu/455 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d924d7e2b7a7e6c752bc97679e612946afc17c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Pouria Pirzadeh <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
