Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1102: VarSize Encoding to store length of String and ByteArray ......................................................................
Patch Set 5: (16 comments) https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-app/src/test/resources/runtimets/only.xml File asterix-app/src/test/resources/runtimets/only.xml: Line 18: ~ under the License. > Why did you change '!' to '~'? I'm using a update copyright plugin in Intelij, I guess it treats the xml file differently. Fixed. https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-app/src/test/resources/runtimets/results/string/matches11/matches11.1.adm File asterix-app/src/test/resources/runtimets/results/string/matches11/matches11.1.adm: Line 5: , null > How did the space get here? Done. https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java File asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java: Line 447: private final AStringSerializerDeserializer aStringDerDer = new AStringSerializerDeserializer(); > Is "aStringDerDer" intended? Not intended.... Fixed to aStringSerDer https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java File asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java: Line 370: private final AStringSerializerDeserializer aStringDerDer = new AStringSerializerDeserializer(); > "aStringDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java: Line 40: private final AObjectSerializerDeserializer aObjDerDer = new AObjectSerializerDeserializer(); > "aObjDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java: Line 43: private final AObjectSerializerDeserializer aObjDerDer = new AObjectSerializerDeserializer(); > "aObjDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/NestedDatatypeNameValueExtractor.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/NestedDatatypeNameValueExtractor.java: Line 46: private final AObjectSerializerDeserializer aObjDerDer = new AObjectSerializerDeserializer(); > "aObjDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AObjectSerializerDeserializer.java File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AObjectSerializerDeserializer.java: Line 61: private final ABinarySerializerDeserializer aBinaryDerDer = new ABinarySerializerDeserializer(); > "aStringDerDer" and "aBinaryDerDer" ? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java: Line 55: private final AStringSerializerDeserializer aStringDerDer = new AStringSerializerDeserializer(); > "aStringDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-om/src/test/java/org/apache/asterix/dataflow/data/nontagged/printers/ABinaryPrinterTest.java File asterix-om/src/test/java/org/apache/asterix/dataflow/data/nontagged/printers/ABinaryPrinterTest.java: Line 69: char[] chars = new char[65540 * 2]; > What is the meaning of this constant? Can we give it a name? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsNullDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsNullDescriptor.java: Line 63: private final AObjectSerializerDeserializer aObjDerDer = new AObjectSerializerDeserializer(); > "aObjectDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsSystemNullDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsSystemNullDescriptor.java: Line 63: private final AObjectSerializerDeserializer aObjDerDer = new AObjectSerializerDeserializer(); > "aObjDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SpatialIntersectDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SpatialIntersectDescriptor.java: Line 87: private final AObjectSerializerDeserializer aObjDerDer = new AObjectSerializerDeserializer(); > "aObjDerDer"? Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringContainsDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringContainsDescriptor.java: Line 68: return AsterixBuiltinFunctions.STRING_CONTAINS; > Nice :) Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringEndsWithDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringEndsWithDescriptor.java: Line 70: return AsterixBuiltinFunctions.STRING_ENDS_WITH; > And another one :) Done https://asterix-gerrit.ics.uci.edu/#/c/450/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeDescriptor.java: Line 93: private final AStringSerializerDeserializer aStringDerDer = new AStringSerializerDeserializer(); > "aStringDerDer"? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/450 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41fff780f5c071742ef10129d83c8f945d5886d7 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
