Steven Jacobs has posted comments on this change. Change subject: Convert comparisons with current-datetime, current-date, and current-time to applicable index searches as though they were constants ......................................................................
Patch Set 3: I'll upload a new patchiest with changes. As far as your issue with "null" floating around some places, the reason I did this was because the abstractintroduceaccessmethod functions are used by multiple cases (e.g. join vs select) so I was using a null to flag when my new stuff is actually relevant. As an example of what I mean: Look at the calls to pruneindexcandidates and analyzecondition. When called from introduce select, they are given the type environment. In introduce join, the new stuff is irrelevant so we pass null as the type environment. I'm not sure what the better solution is for that. -- To view, visit https://asterix-gerrit.ics.uci.edu/367 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied64276873afcfbdd31dac313009e47429d8f9b0 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: No
