Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1102: VarSize Encoding to store length of String and ByteArray ......................................................................
Patch Set 9: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/450/9/asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java File asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java: Line 238: FilesIndexDescription filesIndexDescription = new FilesIndexDescription(); > What's the purpose of this? Preston also asked about this. This FileIndexDescription is not static object anymore. The reason is the same as the Serializer and Deserializer is not static method. https://asterix-gerrit.ics.uci.edu/#/c/450/9/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java File asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java: Line 114: if (FailedGroup != null && FailedGroup.getTestCase().size() > 0) { > Great! Done https://asterix-gerrit.ics.uci.edu/#/c/450/9/asterix-app/src/test/resources/runtimets/queries/string/end-with1/end-with1.3.query.aql File asterix-app/src/test/resources/runtimets/queries/string/end-with1/end-with1.3.query.aql: Line 21: let $c1 := ends-with("hello world","werld") > Can we also change test filenames and directories (endswith, startswith)? Done. It's really a hard work. :-) https://asterix-gerrit.ics.uci.edu/#/c/450/9/asterix-app/src/test/resources/runtimets/queries/string/matches11/matches11.3.query.aql File asterix-app/src/test/resources/runtimets/queries/string/matches11/matches11.3.query.aql: Line 27: null, > we want to test null comparison too? It is related to the https://issues.apache.org/jira/browse/ASTERIXDB-1131. We have a bug that it doesn't show the generated null in a list if I didn't explicitly tell that there is a null. https://asterix-gerrit.ics.uci.edu/#/c/450/9/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java: Line 194: int position = s + UTF8StringUtil.getNumBytesToStoreLength(stringLength); // skip 2 bytes containing string size > Now, the comment is wrong, right? And, can we move these functions to hyrac Comment removed. All these function could be moved downward. But I'm thinking these output formats are asterix-specific (like the way to handling the quote). So it would be safer to stay here. -- To view, visit https://asterix-gerrit.ics.uci.edu/450 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41fff780f5c071742ef10129d83c8f945d5886d7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
