Ildar Absalyamov has posted comments on this change. Change subject: ASTERIXDB-1109: Fixed deletion of records from open secondary index ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/462/3/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AlgebricksOptimizationContext.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AlgebricksOptimizationContext.java: Line 326: } > The purpose of this? I can guess. But, I would like to make sure. Previously I was trying to do plan analysis to get the variable, holding the record, given variables, holding PKs. It turned out the context already holds mapping form record to PKs, but I needed the opposite. So I though of adding another map in opposite direction. Alternative is to keep the same API call findRecord(List<LogicalVariable> pkVars), and traverse through recordToPrimaryKey map, but thats O(n) instead of O(1) -- To view, visit https://asterix-gerrit.ics.uci.edu/462 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2036d2eac4b0a0c6ac2c2e7e1bac383b11106bd Gerrit-PatchSet: 3 Gerrit-Project: hyracks Gerrit-Branch: release-0.2.18 Gerrit-Owner: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
