abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1126 Correct comparators and type traits for external index ......................................................................
Patch Set 8: (5 comments) All of these additional imports appeared when I resolved rebase merge conflicts. I cleaned them out. Thanks Till, Abdullah https://asterix-gerrit.ics.uci.edu/#/c/455/8/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java File asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java: Line 84: Path destDir = new Path(HDFS_PATH); > What's the difference between hdfsPath and HDFS_PATH? Could you choose name Done https://asterix-gerrit.ics.uci.edu/#/c/455/8/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java File asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java: Line 34: import org.apache.asterix.test.aql.TestsUtils; > Why do we need a new import here? Done https://asterix-gerrit.ics.uci.edu/#/c/455/8/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixClusterLifeCycleIT.java File asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixClusterLifeCycleIT.java: Line 43: import org.apache.asterix.testframework.context.TestCaseContext; > Why do we need new imports here? Done https://asterix-gerrit.ics.uci.edu/#/c/455/8/asterix-installer/src/test/java/org/apache/asterix/installer/transaction/DmlRecoveryIT.java File asterix-installer/src/test/java/org/apache/asterix/installer/transaction/DmlRecoveryIT.java: Line 40: import org.apache.asterix.testframework.xml.TestCase.CompilationUnit; > Why do we need new imports here? Done https://asterix-gerrit.ics.uci.edu/#/c/455/8/asterix-installer/src/test/java/org/apache/asterix/installer/transaction/RecoveryIT.java File asterix-installer/src/test/java/org/apache/asterix/installer/transaction/RecoveryIT.java: Line 39: import org.apache.asterix.testframework.context.TestCaseContext; > Do we need to import the TestCaseContext here? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/455 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d924d7e2b7a7e6c752bc97679e612946afc17c Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Pouria Pirzadeh <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
